CQL Heuristics Calculator by gonzalotguerrero · Pull Request #1620 · WebFuzzing/EvoMaster

gonzalotguerrero · 2026-07-01T21:37:09Z

Added CassandraHeuristicsCalculator/CassandraOperationEvaluator to compute a distance heuristic for CQL WHERE clauses

Distance calculation for each operator/data type follows the spec from this document

…alculator

…sion-replacement-v2

jgaleotti · 2026-07-08T18:04:24Z

+
+    private final CassandraOperationEvaluator evaluator = new CassandraOperationEvaluator();
+
+    public double computeDistance(String cqlQuery, Iterable<Map<String, Object>> allRows) {


add an abstraction for allRows.

add Javadoc

jgaleotti · 2026-07-08T18:14:52Z

+
+    private enum ComparisonType { EQUALS, GT, GTE, LT, LTE }
+
+    public Truthness evaluate(CqlQueryOperation op, Map<String, Object> row) {


Add Javadoc for method

jgaleotti · 2026-07-08T18:15:03Z

+
+import static org.evomaster.client.java.controller.cassandra.CassandraHeuristicsCalculator.*;
+
+public class CassandraOperationEvaluator {


Add Javadoc for class

jgaleotti · 2026-07-08T18:18:17Z

+        return any(op.getValue(), toElementList(rawCol));
+    }
+
+    private Truthness evaluateContainsKey(ContainsKeyOperation<?> op, Map<String, Object> row) {


use abstraction for Row

jgaleotti · 2026-07-08T18:30:49Z

+
+    public Truthness evaluate(CqlQueryOperation op, Map<String, Object> row) {
+        if (op instanceof AndOperation)
+            return evaluateAnd((AndOperation) op, row);


add {...} for each if. Avoid one if-liners.

jgaleotti · 2026-07-08T18:38:36Z

+
+    private static String normalizeColumnName(String name) {
+        if (name == null) return null;
+        if (name.startsWith("\"") && name.endsWith("\"")) {


replace " with constant value

jgaleotti · 2026-07-08T18:38:56Z

+        return Collections.emptyList();
+    }
+
+    private static String normalizeColumnName(String name) {


add Javadoc explaining what normalization means for a column name

jgaleotti · 2026-07-08T18:39:57Z

+        this.nanos  = nanos;
+    }
+
+    public static CqlDurationLiteral parse(String text) {


Move this code to a specific parser for this format.

- Small refactorings to follow dev guidelines - Refactor parsing of Duration literals and reorganise packages - Unify distance calculation for strings - Refactor operation evaluator - Add javadoc for calculator and CassandraRow abstraction

- More refactorings in parser utils - Add missing docs in parser utils

…sion-replacement-v2

jgaleotti · 2026-07-09T20:21:48Z

+            return compareDuration(rowValue, literalValue, comparisonType);
+        }
+
+        SimpleLogger.uniqueWarn("CassandraHeuristicsCalculator: unsupported type "


If the type is not unsupported it should throw an exception

jgaleotti · 2026-07-09T20:26:06Z

+        }
+    }
+
+    private static Instant parseTimestampString(String rowValue) {


Please improve the readability of this method. Consider adding different methods to try to parse different formats.

jgaleotti · 2026-07-09T20:32:43Z

+        throw new IllegalArgumentException("Cannot parse timestamp string: " + rowValue);
+    }
+
+    private static boolean isCqlDuration(Object rowValue) {


I am a bit skeptical of using reflection here to handle CqlDuration. What do you think of using java.time.temporal.TemporalAmount instead of CqlDuration ? Can we get rid of reflection ?

jgaleotti · 2026-07-09T20:33:03Z

+                .equals("com.datastax.oss.driver.api.core.data.CqlDuration");
+    }
+
+    private static int getDurationMonths(Object durationRowValue) throws Exception {


use java.time.temporal.TemporalAmount?

jgaleotti · 2026-07-09T20:33:08Z

+        return (int) durationRowValue.getClass().getMethod("getMonths").invoke(durationRowValue);
+    }
+
+    private static int getDurationDays(Object durationRowValue) throws Exception {


use java.time.temporal.TemporalAmount?

jgaleotti · 2026-07-09T20:35:15Z

+                    TruthnessUtils.getEqualityTruthness(nanos, literalDurationValue.nanos)
+            );
+        } catch (Exception e) {
+            return FALSE_TRUTHNESS;


why a try-catch here? What are the expected exceptions at this point?

jgaleotti · 2026-07-09T20:37:44Z

+     * {@code mo}, or {@code ms} consuming {@code m}.
+     */
+    private static final Pattern TOKEN =
+            Pattern.compile("(\\d+)(mo|ms|µs|us|ns|y|d|h|m|s)", Pattern.CASE_INSENSITIVE);


replace mo, ms, us, µs, ns, y, d, h, m, s with corresponding constant values

jgaleotti · 2026-07-09T20:38:03Z

+    private static CqlDurationLiteral parseIso(String isoDuration) {
+        // Split on T (or t) to separate date and time parts
+        String upper = isoDuration.toUpperCase();
+        int tIndex = upper.indexOf('T');


replace 'T' with constant value

jgaleotti · 2026-07-09T20:38:25Z

+            long value = Long.parseLong(m.group(1));
+            String unit = m.group(2).toLowerCase();
+            switch (unit) {
+                case "y":  months += (int)(value * 12);                    break;


replace these strings with constant values

jgaleotti · 2026-07-09T20:39:06Z

+     * @return {@code true} if {@code cqlCommand} is a SELECT statement
+     */
    public static boolean isSelect(String cqlCommand) {
        return cqlCommand.trim().toUpperCase().startsWith("SELECT");


replace "SELECT", "UPDATE", etc with constants

…ent-v2 More CqlSession Replacements

gonzalotguerrero added 15 commits June 19, 2026 16:49

Merge branch 'master' into feature/cql-heuristics-calculator

76bb1fb

First calculator draft

92aa301

Merge branch 'master' into feature/cql-heuristics-calculator

56c806a

Merge branch 'feature/cql-query-parser' into feature/cql-heuristics-c…

c80e69d

…alculator

Fix comparison of time-related values

6b6ad91

Improve test class coverage

059e9a5

Add support for integer constants in time-related types

8455eb6

Merge branch 'master' into feature/cql-heuristics-calculator

b6e870b

Created CassandraOperationEvaluator

a796494

Minor refactorings

bcf43e2

Add more replacements for overloaded execute method

6dd2267

Add separate fields for keyspace and table in ExecutedCqlCommand

ec7e7f3

Merge branch 'master' into feature/cql-heuristics-calculator

d28282c

Merge branch 'master' into feature/cql-session-replacement-v2

f8ccc59

Merge branch 'feature/cql-heuristics-calculator' into feature/cql-ses…

f61c578

…sion-replacement-v2

gonzalotguerrero requested a review from jgaleotti July 6, 2026 21:20

jgaleotti requested changes Jul 8, 2026

View reviewed changes

gonzalotguerrero added 3 commits July 8, 2026 20:09

PR review comments

288be95

- Small refactorings to follow dev guidelines - Refactor parsing of Duration literals and reorganise packages - Unify distance calculation for strings - Refactor operation evaluator - Add javadoc for calculator and CassandraRow abstraction

Improve CqlParserUtils

8a566ee

- More refactorings in parser utils - Add missing docs in parser utils

Merge branch 'master' into feature/cql-heuristics-calculator

c9028dd

gonzalotguerrero requested a review from jgaleotti July 9, 2026 03:23

gonzalotguerrero added 2 commits July 9, 2026 01:45

Divide regex to improve readability

d19881f

Merge branch 'feature/cql-heuristics-calculator' into feature/cql-ses…

5263ce5

…sion-replacement-v2

jgaleotti requested changes Jul 9, 2026

View reviewed changes

arcuri82 and others added 2 commits July 10, 2026 12:53

Merge pull request #1629 from WebFuzzing/feature/cql-session-replacem…

432b4c7

…ent-v2 More CqlSession Replacements

Evaluator and parsers refactorings

2cc704e


		private final CassandraOperationEvaluator evaluator = new CassandraOperationEvaluator();

		public double computeDistance(String cqlQuery, Iterable<Map<String, Object>> allRows) {


		private enum ComparisonType { EQUALS, GT, GTE, LT, LTE }

		public Truthness evaluate(CqlQueryOperation op, Map<String, Object> row) {


		import static org.evomaster.client.java.controller.cassandra.CassandraHeuristicsCalculator.*;

		public class CassandraOperationEvaluator {

Uh oh!

Conversation

gonzalotguerrero commented Jul 1, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants