ci: Windows Ninja build fix and MSVC updates - #2846
Open
kevmoo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-S . -B out -G Ninjainstead of manually creating directories and usingworking-directory: out.-G Ninjaflag, ensuring it actually uses the Ninja binary installed in the previous step.ilammy/msvc-dev-cmd@v1for Windows CI builds./Zi /Od /FStoWASM2C_CFLAGSwhen compiling with MSVC in Debug mode to avoid concurrent PDB write locks.Split out from #2717.