Skip to content

Fix cont.wast func returning a cont ref to JS #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgmccabe merged 1 commit into from
Mar 5, 2026
Merged

Fix cont.wast func returning a cont ref to JS #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/core/stack-switching/cont.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,11 @@
)
)

(func (export "null-new") (result (ref null $k1))
(func (export "null-new")
(cont.new $k1
(ref.null $f1)
)
(unreachable)
Copy link
Member

@tlively tlively Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general tools/engines other than the reference interpreter do not actually compare their error messages against the error messages in assert_trap assertions because it is expected that their error messages might be different. The trap from the unreachable here can therefore make the test appear to pass even if there is a bug that lets cont.new succeed without trapping. It would be better to use a drop instead.

)
)

Expand Down