[Spec] Soundness: Make Limit max be unconstrained in Store and Store Extension Relations#2185
Merged
Merged
Conversation
rossberg
reviewed
Jun 10, 2026
rossberg
left a comment
Member
There was a problem hiding this comment.
Thanks, looks good to me. Is there a reason why you didn't include the fixes for 1.0 and 2.0?
Contributor
Author
It would require adding the soundness files for Wasm 1.0 and 2.0, which could be done, though I feel like this isn't the right place to do it. Perhaps in another PR? |
rossberg
approved these changes
Jun 10, 2026
rossberg
left a comment
Member
There was a problem hiding this comment.
Ah, right. Yes, can't harm to add those in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, some of the store relations had been constrained to only having defined max for memory and table types, i.e.
Here, m can only be defined. This PR is made to fix this issue.