Skip to content

[Spec] Soundness: Make Limit max be unconstrained in Store and Store Extension Relations#2185

Merged
rossberg merged 1 commit into
WebAssembly:mainfrom
Wasm-DSL:soundness-max-fix
Jun 10, 2026
Merged

[Spec] Soundness: Make Limit max be unconstrained in Store and Store Extension Relations#2185
rossberg merged 1 commit into
WebAssembly:mainfrom
Wasm-DSL:soundness-max-fix

Conversation

@DCupello1

Copy link
Copy Markdown
Contributor

Previously, some of the store relations had been constrained to only having defined max for memory and table types, i.e.

rule Extend_meminst:
  {TYPE at `[n..m] PAGE, BYTES b*} `<= {TYPE at `[n'..m] PAGE, BYTES b'*}
  -- if n <= n'
  -- if |b*| <= |b'*|

Here, m can only be defined. This PR is made to fix this issue.

@rossberg rossberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. Is there a reason why you didn't include the fixes for 1.0 and 2.0?

@DCupello1

Copy link
Copy Markdown
Contributor Author

Thanks, looks good to me. Is there a reason why you didn't include the fixes for 1.0 and 2.0?

It would require adding the soundness files for Wasm 1.0 and 2.0, which could be done, though I feel like this isn't the right place to do it. Perhaps in another PR?

@rossberg rossberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Yes, can't harm to add those in another PR.

@rossberg rossberg merged commit 7827c14 into WebAssembly:main Jun 10, 2026
9 checks passed
@rossberg rossberg deleted the soundness-max-fix branch June 10, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants