[CI] Build on macos-14 rather than macos-latest

[sbc100]

In emsdk we actually build on macos-13, but sadly there is not macos-13 available in github actions.

In doing this I'm trying to get binaryen CI to reproduce the current issue we are seeing in emsdk CI:

In file included from /Users/distiller/project/binaryen/main/src/ir/import-names.h:23:
/Users/distiller/project/binaryen/main/src/support/name.h:35:12: error: call to implicitly-deleted default constructor of 'wasm::IString'
  Name() : IString() {}
           ^
/Users/distiller/project/binaryen/main/src/support/istring.h:72:3: note: explicitly defaulted function was implicitly deleted here
  IString() = default;
  ^
/Users/distiller/project/binaryen/main/src/support/istring.h:68:14: note: default constructor of 'IString' is implicitly deleted because field 'str' of const-qualified type 'const wasm::IString::View' would not be initialized
  const View str;
             ^

Split out from #8719

[sbc100]

It looks like that particular issue does not show up with macOS 14, but I still think we should land this anyway to get us a little closer.

[kripken]

Please update .github/workflows/create_release.yml so the files are in sync, to avoid errors showing up in release builds.

[sbc100]

Please update .github/workflows/create_release.yml so the files are in sync, to avoid errors showing up in release builds.

Done.

I don't suppose there might be reason to prefer the latest macOS/clang for building the release?

I guess it would be bad to have them be out-of-sync since we could end up with failures that we don't see until release time.

[kripken]

I'm not aware of benefits of using later OS versions for releases. Usually the opposite is the case I think?

But maybe we should test the release builds on latest macos too? That would avoid any surprises here.

[sbc100]

I think its probably simplest to just keep them in sync, unless we have good reason to want to build+test twice on macOS.

[kripken]

I am saying we can keep the builds in sync, but add testing of the builds on latest. But maybe that's not worth it.

[kripken]

Can this be startsWith too?

[sbc100]

Actually I think is supposed pick out exactly two specific builds. (i.e. if we have mulitple macos builds we would only want the one to match here).

[kripken]

Oh, I see. sgtm

[kripken]

@sbc100 It looks like this caused us to rename our macos builds, adding a -14 postfix:

https://github.com/WebAssembly/binaryen/releases/tag/version_130

Note `binaryen-version_130-x86_64-macos-14.tar.gz. In comparison, in the last release,

https://github.com/WebAssembly/binaryen/releases/tag/version_129

The name is simpler, no -14: binaryen-version_129-x86_64-macos.tar.gz

Something with that sed command..?

[kripken]

Perhaps we need to add something here?

binaryen/.github/workflows/create_release.yml

Line 69 in e48f899

OSNAME=$(echo ${{ matrix.os }} | sed 's/-latest//')

[sbc100]

Yes, it looks like that line also needs | sed 's/-14//'

[sbc100]

Fix is in #8837.

For the current release you can probably just manually rename of the file (You might need to download it and upload it with a different name)