Skip to content

Canonicalize NaNs when casting between float and double #8645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenfontanella wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Canonicalize NaNs when casting between float and double #8645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/wasm/literal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ Literal Literal::extendToUI64() const {

Literal Literal::extendToF64() const {
assert(type == Type::f32);
return Literal(double(getf32()));
return standardizeNaN(Literal(static_cast<double>(getf32())));
}

Literal Literal::extendS8() const {
Expand Down Expand Up @@ -1164,7 +1164,7 @@ Literal Literal::sqrt() const {
Literal Literal::demote() const {
auto f64 = getf64();
if (std::isnan(f64)) {
return Literal(float(f64));
return standardizeNaN(Literal(static_cast<float>(f64)));
}
if (std::isinf(f64)) {
return Literal(float(f64));
Expand Down Expand Up @@ -2786,7 +2786,8 @@ template<LaneOrder Side> Literal extendF32(const Literal& vec) {
LaneArray<2> result;
for (size_t i = 0; i < 2; ++i) {
size_t idx = (Side == LaneOrder::Low) ? i : i + 2;
result[i] = Literal((double)lanes[idx].getf32());
result[i] = Literal::standardizeNaN(
Literal(static_cast<double>(lanes[idx].getf32())));
}
return Literal(result);
}
Expand Down
Loading