Skip to content

Improve indirect call effects in GlobalEffects#8628

Merged
stevenfontanella merged 3 commits intoindirect-effects-sccfrom
indirect-effects-address
Apr 23, 2026
Merged

Improve indirect call effects in GlobalEffects#8628
stevenfontanella merged 3 commits intoindirect-effects-sccfrom
indirect-effects-address

Conversation

@stevenfontanella
Copy link
Copy Markdown
Member

@stevenfontanella stevenfontanella commented Apr 20, 2026

Part of #8615. We currently union the effects of all functions of a given type when computing the effects for indirect calls. Make this more precise by excluding effects of functions that never have their address taken.

Comment thread src/passes/GlobalEffects.cpp Outdated
@stevenfontanella stevenfontanella force-pushed the indirect-effects-address branch from 6214fa3 to 36f9b09 Compare April 22, 2026 23:56
@stevenfontanella stevenfontanella changed the title Account for addressed funcs Improve indirect call effects in GlobalEffects Apr 22, 2026
@stevenfontanella stevenfontanella force-pushed the indirect-effects-address branch from 36f9b09 to 77e19e1 Compare April 23, 2026 00:02
@stevenfontanella stevenfontanella force-pushed the indirect-effects-address branch from 77e19e1 to 08888b8 Compare April 23, 2026 00:24
@stevenfontanella stevenfontanella marked this pull request as ready for review April 23, 2026 01:05
@stevenfontanella stevenfontanella requested a review from a team as a code owner April 23, 2026 01:05
@stevenfontanella stevenfontanella requested review from aheejin and removed request for a team April 23, 2026 01:05
@stevenfontanella stevenfontanella merged commit 94914c9 into indirect-effects-scc Apr 23, 2026
11 of 32 checks passed
@stevenfontanella stevenfontanella deleted the indirect-effects-address branch April 23, 2026 17:54
@stevenfontanella stevenfontanella restored the indirect-effects-address branch April 23, 2026 19:57
@stevenfontanella
Copy link
Copy Markdown
Member Author

Accidentally merged this into my WIP branch and I can't re-open this. Continuing in #8644.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants