Use effects for indirect call expressions#8625
Draft
stevenfontanella wants to merge 1 commit intomainfrom
Draft
Conversation
stevenfontanella
force-pushed
the
expression-effects
branch
from
690ee8d to
75481a7
Compare
tlively
reviewed
Apr 20, 2026
| void visitCallIndirect(CallIndirect* curr) { | ||
| if (auto it = parent.module.typeEffects.find(curr->heapType); | ||
| it != parent.module.typeEffects.end()) { | ||
| parent.mergeIn(*it->second); |
Member
There was a problem hiding this comment.
It doesn't look like this accounts for the possible trap from a bad type check. I guess the previous code didn't need to handle it because setting calls implicitly includes trapping along with most other effects.
To make this as precise as possible, we could look at the type of the table and skip setting the trap effect if it is non-nullable and a subtype of the call_indirect expected type.
stevenfontanella
force-pushed
the
indirect-effects-scc
branch
from
189d543 to
2630eff
Compare
stevenfontanella
force-pushed
the
expression-effects
branch
from
75481a7 to
36a4fb5
Compare
Member
Author
|
Seems like JJ + Github don't play well when I'm on a branch based on another branch that had a merge commit. Will fix this after merging the other branch. |
stevenfontanella
added a commit
that referenced
this pull request
Apr 24, 2026
When running in --closed-world, compute effects for indirect calls by unioning the effects of all potential functions of that type. In --closed-world, we assume that all references originate in our module, so the only possible functions that we don't know about are imports. Previously [we gave up on effects analysis](https://github.com/WebAssembly/binaryen/blob/29b2d42e8a748fbe1095696d58a52b7bf83e2253/src/passes/GlobalEffects.cpp#L83-L87) for indirect calls. Yields a very small byte count reduction in calcworker (3799354 - 3799297 = 57 bytes). Also shows no significant difference in Binaryen runtime: (0.1346069 -> 0.13375045 = <1% improvement, probably within noise). We expect more benefits after we're able to share indirect call effects with other passes, since currently they're only seen one layer up for callers of functions that indirectly call functions (see the newly-added tests for examples). Followups: * Share effect information per type with other passes besides just via Function::effects (#8625) * Exclude functions that don't have an address (i.e. functions that aren't the target of ref.func) from effect analysis () * Compute effects more precisely for exact + nullable/non-nullable references Part of #8615.
stevenfontanella
force-pushed
the
expression-effects
branch
from
36a4fb5 to
e65a243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.