Skip to content

Handle nullexnref on JS boundary #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 5 commits into from
Mar 10, 2026
+69 −11
Merged

Handle nullexnref on JS boundary #8437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6a0e07
Handle nullexnref on JS boundary
tlively Mar 10, 2026
a3c65f7
results, too
tlively Mar 10, 2026
3af391f
update test
tlively Mar 10, 2026
0b48a8d
Apply suggestions from code review
tlively Mar 10, 2026
4c0ff1a
format
tlively Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/tools/execution-results.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,13 @@ struct LoggingExternalInterface : public ShellExternalInterface {
Literals arguments;
for (const auto& param : sig.params) {
// An i64 param can work from JS, but fuzz_shell provides 0, which errors
// on attempts to convert it to BigInt. v128 and exnref are disalloewd.
if (param == Type::i64 || param == Type::v128 || param.isExn()) {
// on attempts to convert it to BigInt. v128 is disallowed.
if (param == Type::i64 || param == Type::v128) {
throwJSException();
}
// Exnref and nullexnref are also disallowed.
if (param.isRef() &&
HeapType(param.getHeapType().getTop()).isMaybeShared(HeapType::exn)) {
throwJSException();
}
if (!param.isDefaultable()) {
Expand All @@ -332,9 +337,11 @@ struct LoggingExternalInterface : public ShellExternalInterface {
// Error on illegal results. Note that this happens, as per JS semantics,
// *before* the call.
for (const auto& result : sig.results) {
// An i64 result is fine: a BigInt will be provided. But v128 and exnref
// still error.
if (result == Type::v128 || result.isExn()) {
// An i64 result is fine: a BigInt will be provided. But v128 and
// [null]exnref still error.
if (result == Type::v128 ||
(result.isRef() && HeapType(result.getHeapType().getTop())
.isMaybeShared(HeapType::exn))) {
throwJSException();
}
}
Expand Down
63 changes: 57 additions & 6 deletions test/lit/exec/fuzzing-api.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,23 +357,66 @@
)
)

(func $illegal-result (result v128)
(func $illegal-v128-result (result v128)
;; Helper for the function below. The result is illegal for JS.
(call $log-i32
(i32.const 910)
)
(v128.const i32x4 1 2 3 4)
)

;; CHECK: [fuzz-exec] calling ref.calling.illegal-result
;; CHECK: [fuzz-exec] calling ref.calling.illegal-v128-result
;; CHECK-NEXT: [LoggingExternalInterface logging 1]
(func $ref.calling.illegal-result (export "ref.calling.illegal-result")
(func $ref.calling.illegal-v128-result (export "ref.calling.illegal-v128-result")
;; The v128 result causes an error here, so we will log 1 as an exception. The JS
;; semantics determine that we do that check *before* the call, so the logging
;; of 910 does not go through.
(call $log-i32
(call $call.ref.catch
(ref.func $illegal-result)
(ref.func $illegal-v128-result)
)
)
)

(func $illegal-exnref-result (result exnref)
;; Helper for the function below. The result is illegal for JS.
(call $log-i32
(i32.const 911)
)
(block $l (result exnref)
(try_table (catch_all_ref $l)
(call $throwing)
)
(unreachable)
)
)

;; CHECK: [fuzz-exec] calling ref.calling.illegal-exnref-result
;; CHECK-NEXT: [LoggingExternalInterface logging 1]
(func $ref.calling.illegal-exnref-result (export "ref.calling.illegal-exnref-result")
;; As above with the v128, the exnref cannot be converted to a JS value.
(call $log-i32
(call $call.ref.catch
(ref.func $illegal-exnref-result)
)
)
)

(func $illegal-nullexnref-result (result nullexnref)
;; Helper for the function below. The result is illegal for JS.
(call $log-i32
(i32.const 912)
)
(ref.null noexn)
)

;; CHECK: [fuzz-exec] calling ref.calling.illegal-nullexnref-result
;; CHECK-NEXT: [LoggingExternalInterface logging 1]
(func $ref.calling.illegal-nullexnref-result (export "ref.calling.illegal-nullexnref-result")
;; As above, the nullexnref cannot be converted to a JS value.
(call $log-i32
(call $call.ref.catch
(ref.func $illegal-nullexnref-result)
)
)
)
Expand Down Expand Up @@ -564,7 +607,13 @@
;; CHECK: [fuzz-exec] calling ref.calling.illegal-exnref
;; CHECK-NEXT: [LoggingExternalInterface logging 1]

;; CHECK: [fuzz-exec] calling ref.calling.illegal-result
;; CHECK: [fuzz-exec] calling ref.calling.illegal-v128-result
;; CHECK-NEXT: [LoggingExternalInterface logging 1]

;; CHECK: [fuzz-exec] calling ref.calling.illegal-exnref-result
;; CHECK-NEXT: [LoggingExternalInterface logging 1]

;; CHECK: [fuzz-exec] calling ref.calling.illegal-nullexnref-result
;; CHECK-NEXT: [LoggingExternalInterface logging 1]

;; CHECK: [fuzz-exec] calling ref.calling.legal-result
Expand Down Expand Up @@ -592,8 +641,10 @@
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.catching
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal-exnref
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal-result
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal-exnref-result
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal-nullexnref-result
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal-v128
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.illegal-v128-result
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.legal
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.legal-result
;; CHECK-NEXT: [fuzz-exec] comparing ref.calling.rethrow
Expand Down
Loading