Skip to content

LegalizeAndPruneJSInterface: Prune illegal globals #8435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Mar 10, 2026
Merged

LegalizeAndPruneJSInterface: Prune illegal globals #8435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/passes/LegalizeJSInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,19 @@ struct LegalizeAndPruneJSInterface : public LegalizeJSInterface {
ReFinalize().run(getPassRunner(), module);
ReFinalize().runOnModuleCode(getPassRunner(), module);

// TODO: globals etc.
// Globals.
std::vector<Name> illegalExports;
for (auto& exp : module->exports) {
if (exp->kind == ExternalKind::Global) {
auto name = *exp->getInternalName();
if (isIllegal(module->getGlobal(name)->type)) {
illegalExports.push_back(exp->name);
}
}
}
for (auto name : illegalExports) {
module->removeExport(name);
}
}

bool isIllegal(Type type) {
Expand Down
15 changes: 15 additions & 0 deletions test/lit/passes/legalize-and-prune-js-interface.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,23 @@
;; and also prune the export, so it remains neither an import nor an export.
(export "imported-v128" (func $imported-v128))
)

;; CHECK: (type $0 (func (result v128)))

;; CHECK: (func $imported-v128 (type $0) (result v128)
;; CHECK-NEXT: (v128.const i32x4 0x00000000 0x00000000 0x00000000 0x00000000)
;; CHECK-NEXT: )
(module
;; CHECK: (global $i32 i32 (i32.const 42))
(global $i32 i32 (i32.const 42))

;; CHECK: (global $v128 v128 (v128.const i32x4 0x00000000 0x00000000 0x00000000 0x00000000))
(global $v128 v128 (v128.const i32x4 0x00000000 0x00000000 0x00000000 0x00000000))

;; The illegal export will vanish, but not the legal one.

(export "illegal" (global $v128))
;; CHECK: (export "legal" (global $i32))
(export "legal" (global $i32))
)

Loading