Open
Conversation
5b361b4 to
c7fcea9
Compare
c7fcea9 to
d7c1324
Compare
tlively
reviewed
Mar 5, 2026
Comment on lines
+382
to
+383
| if (!val.type.isRef() || | ||
| !HeapType::isSubType(val.type.getHeapType(), ref->type)) { |
Member
There was a problem hiding this comment.
We should probably check that the value is not null here, too.
|
|
||
| if (auto* v = std::get_if<Literal>(&expected)) { | ||
| if (val != *v) { | ||
| if (val.type.isVector() && v->type.isVector() && isAlternative) { |
Member
There was a problem hiding this comment.
It's not clear to me why we check isAlternative here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example failure:
Example failure with SIMD from
relaxed_min_max.wast:Part of #8261 and #8315. Fixes
i16x8_relaxed_q15mulr_s.wast,i8x16_relaxed_swizzle.wast,relaxed_madd_nmadd.wastspec tests, and partially fixesrelaxed_dot_product.wast,relaxed_laneselect.wast,relaxed_min_max.wast, andthreads/thread.wast.