Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| const clonedRequest = deepClone(req); | ||
| propagateToRequest(clonedRequest, context); | ||
| return clonedRequest; | ||
| return clonedRequest as ReturnType; |
There was a problem hiding this comment.
Generic parameter shadows built-in TypeScript ReturnType utility
Low Severity
The generic type parameter ReturnType on propagateToMutableRequest shadows TypeScript's built-in ReturnType<T> utility type. This prevents use of the utility type within the function scope and can confuse developers who associate ReturnType with the standard utility. A name like TReturn or Result would avoid the shadowing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Medium Risk
Primarily adds deprecation annotations and export guidance, which may surface new TypeScript/IDE warnings for downstream consumers and prompt migration work. Minor typing change in
propagateToMutableRequestis low runtime risk but could affect compile-time expectations.Overview
Marks the JRPC V1 surface area (engine, middleware types, provider helpers, and postMessage/stream utilities) as deprecated via JSDoc and adds top-level guidance in
src/jrpc/index.tsto migrate to the./v2exports.Improves V2 compatibility typing by making
propagateToMutableRequestgeneric over its return type, and extendscompatibility-utilstests to cover the new generic behavior and default typing.Updates
package-lock.jsonmetadata by removing a number ofpeer: trueflags from dev dependencies.Written by Cursor Bugbot for commit d51d1ff. This will update automatically on new commits. Configure here.