Open
Conversation
added 7 commits
August 21, 2024 23:11
shadeofblue
reviewed
Sep 2, 2024
| return self.connections.get_nowait() | ||
|
|
||
| def new_connection(self) -> EndpointConnection: | ||
| """Internal function, do not call directly""" |
Contributor
There was a problem hiding this comment.
instead of naming it like that, please change the name to __new_connection or _new_connection to make it obvious that it's an internal function...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point is that a part of eth endpoints in the web3proxy can be configured as connected via tunnel.
For that a new class of connection pool is developed: TunnelConnectionPool.
A web3pi tunnel, a server tunnel part, is used.
Closes #75