ci: run the test suite on pull requests - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-packages.yml runs
go test -race ./..., but itson:haspull_requestcommented out and its jobifadditionally requiresgithub.ref == 'refs/heads/main'— so evenworkflow_dispatchon a branch is skipped. The suite therefore only ever ran after a merge.That is how the
attemptCountdata race reachedmain(#3): the PR that introduced it was never able to run the tests.Adds a dedicated
tests.yml—go vet+go test -race ./...on pull requests and on main. NoWAVESPEED_API_KEYis set; the suite passes without credentials (verified locally).Workflow file only. Action SHAs match the ones already pinned in this repository.