Fix proxygen-macros build issues in latest Rust#7
Open
bobomb wants to merge 1 commit intoWarrenHood:mainfrom
Open
Fix proxygen-macros build issues in latest Rust#7bobomb wants to merge 1 commit intoWarrenHood:mainfrom
bobomb wants to merge 1 commit intoWarrenHood:mainfrom
Conversation
…perly in latest rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
proxygen-macroscrate to use the newstd::arch::naked_asm!macro instead of the deprecatedstd::arch::asm!for naked functions. The change is applied across both theforwardandpre_hookmacro implementations, ensuring compatibility with the latest Rust conventions for inline assembly in naked functions. Additionally, the unnecessaryoptions(noreturn)directive is removed from the assembly blocks.Migration to
naked_asm!macro:std::arch::asm!withstd::arch::naked_asm!in theforwardandpre_hookmacro-generated functions to align with updated Rust requirements for naked functions. [1] [2] [3]Assembly options cleanup:
options(noreturn)directive from the inline assembly blocks, as it is not needed withnaked_asm!and may be incompatible. [1] [2] [3]