Skip to content

Fix proxygen-macros build issues in latest Rust#7

Open
bobomb wants to merge 1 commit intoWarrenHood:mainfrom
bobomb:main
Open

Fix proxygen-macros build issues in latest Rust#7
bobomb wants to merge 1 commit intoWarrenHood:mainfrom
bobomb:main

Conversation

@bobomb
Copy link
Copy Markdown

@bobomb bobomb commented Apr 24, 2026

This pull request updates the proxygen-macros crate to use the new std::arch::naked_asm! macro instead of the deprecated std::arch::asm! for naked functions. The change is applied across both the forward and pre_hook macro implementations, ensuring compatibility with the latest Rust conventions for inline assembly in naked functions. Additionally, the unnecessary options(noreturn) directive is removed from the assembly blocks.

Migration to naked_asm! macro:

  • Replaced all uses of std::arch::asm! with std::arch::naked_asm! in the forward and pre_hook macro-generated functions to align with updated Rust requirements for naked functions. [1] [2] [3]

Assembly options cleanup:

  • Removed the options(noreturn) directive from the inline assembly blocks, as it is not needed with naked_asm! and may be incompatible. [1] [2] [3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant