fix: standardize error response format to { message } across all endpoints#183
Open
jakebromberg wants to merge 3 commits intomainfrom
Open
fix: standardize error response format to { message } across all endpoints#183jakebromberg wants to merge 3 commits intomainfrom
jakebromberg wants to merge 3 commits intomainfrom
Conversation
jakebromberg
force-pushed
the
fix/26-error-format-consistency
branch
from
fb9e3a8 to
813682f
Compare
jakebromberg
force-pushed
the
fix/26-error-format-consistency
branch
from
b78cb87 to
152b2eb
Compare
2 tasks
jakebromberg
force-pushed
the
fix/26-error-format-consistency
branch
from
152b2eb to
e4509f0
Compare
AyBruno
requested changes
Mar 9, 2026
Collaborator
AyBruno
left a comment
AyBruno
left a comment
There was a problem hiding this comment.
All of these should actually be turned into instances of WxycError (https://github.com/WXYC/Backend-Service/blob/main/apps/backend/utils/error.ts) and thrown to be caught by our default error handler:
https://github.com/WXYC/Backend-Service/blob/main/apps/backend/app.ts#L70
https://github.com/WXYC/Backend-Service/blob/main/apps/backend/middleware/errorHandler.ts
…oints
Mixed formats (plain strings, { status, message }, leaked error.message)
are now consistently { message: '...' }. Internal errors no longer
expose raw error messages to clients.
Co-authored-by: Cursor <cursoragent@cursor.com>
Replaces res.status().json/send() error patterns with throw new WxycError() so the centralized error handler formats all error responses consistently.
jakebromberg
force-pushed
the
fix/26-error-format-consistency
branch
from
e4509f0 to
15c96a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WxycErrorerrors no longer leak rawerror.messageto clients — they now return{ message: 'Internal server error' }and log the real error viaconsole.errorres.send('plain string')calls withres.json({ message: '...' })and removed the extrastatusfield from{ status, message }response objectstests/unit/middleware/errorHandler.test.tscovering bothWxycErrorand non-WxycErrorpathsTest plan
WxycErrorreturns{ message }with correct status codeWxycErrorreturns generic{ message: 'Internal server error' }(previously leaked raw message)console.erroris called for unhandled errorsMade with Cursor