refactor(Show Work components): Convert to standalone #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 5 blocking issues (5 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
src/assets/wise5/components/embedded/embedded-show-work/embedded-show-work.component.ts
Show resolved
Hide resolved
… show work component is imported separately in grading modules
src/assets/wise5/components/embedded/embedded-show-work/embedded-show-work.component.ts
Show resolved
Hide resolved
…n up related files.
src/assets/wise5/components/embedded/embedded-show-work/embedded-show-work.component.ts
Show resolved
Hide resolved
…mponent, PeerChatQuestionBankComponent to standalone and clean up related files
Comment on lines
56
to
+66
| constructor( | ||
| protected AnnotationService: AnnotationService, | ||
| protected ComponentService: ComponentService, | ||
| protected ConfigService: ConfigService, | ||
| protected annotationService: AnnotationService, | ||
| protected componentService: ComponentService, | ||
| protected configService: ConfigService, | ||
| protected dialog: MatDialog, | ||
| private DiscussionService: DiscussionService, | ||
| protected NodeService: NodeService, | ||
| protected NotebookService: NotebookService, | ||
| private NotificationService: NotificationService, | ||
| protected StudentAssetService: StudentAssetService, | ||
| protected StudentDataService: StudentDataService | ||
| private discussionService: DiscussionService, | ||
| protected nodeService: NodeService, | ||
| protected notebookService: NotebookService, | ||
| private notificationService: NotificationService, | ||
| protected studentAssetService: StudentAssetService, | ||
| protected dataService: StudentDataService |
Comment on lines
26
to
32
| constructor( | ||
| private AnnotationService: AnnotationService, | ||
| private ConfigService: ConfigService, | ||
| private EmbeddedService: EmbeddedService, | ||
| private annotationService: AnnotationService, | ||
| private configService: ConfigService, | ||
| private embeddedService: EmbeddedService, | ||
| protected nodeService: NodeService, | ||
| protected ProjectService: ProjectService, | ||
| protected projectService: ProjectService, | ||
| private sanitizer: DomSanitizer |
Member
Author
|
🎉 This PR is included in version 5.198.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test