Fix minangle forwarding to TetGen and adjust default value#26
Merged
Conversation
We need an additional "/" after the "q" flag, as stated in 10.20347/WIAS.TECHREPORT.13 chapter 4.2.3. The previous default of "20" produces impractical results, so adjest the default to 10.
Member
Author
|
Tests need adjustments to the new meshing. Will change that after the new default etc is approved |
j-fu
reviewed
Jun 24, 2025
j-fu
reviewed
Jun 24, 2025
Member
Author
|
Test values are updated. Is ready for final review and merge |
Member
|
LGTM |
chmerdon
added a commit
to WIAS-PDELib/ExtendableFEM.jl
that referenced
this pull request
Jun 25, 2025
changed test value due to change in grid from WIAS-PDELib/SimplexGridFactory.jl#26
pjaap
pushed a commit
to WIAS-PDELib/ExtendableFEM.jl
that referenced
this pull request
Jun 25, 2025
- changed test value due to change in grid from WIAS-PDELib/SimplexGridFactory.jl#26 - Interesse tolerante for macos tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need an additional
/after theqflag, as stated in 10.20347/WIAS.TECHREPORT.13 in section 4.2.3.The old default of
20seems to large for me. I adjusted it to10forTetGen.Small demo code generating two unit cubes with different
maxvolumeconstains:gridplot(foogrid(h = 0.0001, H=1), Plotter=GLMakie, yplanes = [0.5], scene3d = :LScene)This was the situation before, very poor quality, angle was not respected

This is the situation with

minangle = 20This is the situation with

minangle = 10