Skip to content

ci(checks): run knip in the check gate and name the e2e job for what it runs #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vivswan merged 1 commit into from
Sep 24, 2026
Merged

ci(checks): run knip in the check gate and name the e2e job for what it runs #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
- uses: ./.github/actions/setup
- name: Lint (biome)
run: bun run lint
- name: Unused exports (knip)
run: bun run knip
- name: Lint (architecture)
run: bun run lint:arch
- name: Typecheck
Expand Down Expand Up @@ -116,7 +118,7 @@ jobs:

# The action bundle runs under node24, so node is installed beside bun. The whole corpus runs on every event:
# scenarios, then fuzz.
e2e-smoke:
e2e:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"access": "public"
},
"scripts": {
"check": "bun run lint && bun run lint:arch && bun run check:compat && bun run typecheck && bun run test && bun run build:check",
"check": "bun run lint && bun run knip && bun run lint:arch && bun run check:compat && bun run typecheck && bun run test && bun run build:check",
"check:compat": "bun .github/scripts/check-compat-markers.ts",
"lint": "bun x biome ci --error-on-warnings .",
"lint:yaml": "git ls-files -z '*.yml' '*.yaml' | xargs -0 yamllint -s",
Expand Down
Loading