fix(vtable-search): search expanded master-detail tables (#5036) - #5300
Open
biubiukam wants to merge 2 commits into
Open
fix(vtable-search): search expanded master-detail tables (#5036)#5300biubiukam wants to merge 2 commits into
biubiukam wants to merge 2 commits into
Conversation
Contributor
@biubiukam 请看看审核的问题 优化下吧
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #5036
💡 Background and solution
SearchComponentpreviously scanned only the master table, so matches in expandedMasterDetailPlugindetail tables were missing from the result list and were not highlighted. This change searches the active detail table instances, keeps the target table for each result, applies highlight and focus styles to the matching table, scrolls within that table, and clears highlights from all associated tables.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
pnpm exec jest --runInBand, ESLint, Prettier,git diff --check, andnode common/scripts/install-run-rush.js build --to @visactor/vtable-search.