fix: delete reverse-selected rows correctly#5225
Open
biubiukam wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #5214
💡 Background and solution
VTable Sheet keeps the original drag direction in row selection ranges. When rows are selected from bottom to top, the range has a larger start row than end row.
The context-menu flow previously assumed ascending row ranges in two places:
This change normalizes the row boundaries before checking whether the right-clicked row belongs to the selection and before collecting rows to delete. A regression test covers reverse row selection, right-click preservation, and batch deletion with VTable Sheet's record synchronization mode.
Validation:
@visactor/vtable-pluginsTypeScript compilation@visactor/vtable-plugins: 8 suites, 58 tests@visactor/vtable-sheet: 76 suites, 442 tests@visactor/vtable: 52 suites, 223 tests📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough