Skip to content

fix: hide row series number in aggregation rows#5224

Open
biubiukam wants to merge 2 commits into
VisActor:developfrom
biubiukam:fix/issue-5213-aggregation-series-number
Open

fix: hide row series number in aggregation rows#5224
biubiukam wants to merge 2 commits into
VisActor:developfrom
biubiukam:fix/issue-5213-aggregation-series-number

Conversation

@biubiukam

Copy link
Copy Markdown
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

Fixes #5213

💡 Background and solution

When rowSeriesNumber is used with column aggregation, the series-number value path runs before the aggregation value path. As a result, the aggregation row is treated like a regular data row and displays a row number.

This change returns an empty value for series-number cells that belong to aggregation rows, for both formatted and original cell values. A regression test covers the default bottom aggregation row.

Validation:

  • TypeScript compilation
  • VTable test suite: 53 suites, 224 tests
  • Package pre-push suite, including VTable Sheet, plugins, Gantt, and Vue packages

📝 Changelog

Language Changelog
🇺🇸 English Hide row series numbers in ListTable aggregation rows.
🇨🇳 Chinese 修复 ListTable 聚合行错误显示行序号的问题。

☑️ Self-Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 同时使用 rowSeriesNumber 和 列开启聚合 aggregation 后, 聚合行也显示了行号

1 participant