Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix: unregister array-valued trigger event listeners on release",
"type": "patch"
}
],
"packageName": "@visactor/vchart",
"email": "biukam.w@gmail.com"
}
29 changes: 29 additions & 0 deletions packages/vchart/__tests__/unit/interaction/base-trigger.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { BaseTrigger } from '../../../src/interaction/triggers/base';
import type { IBaseTriggerOptions, ITriggerEventHandler } from '../../../src/interaction/interface/trigger';
import type { IInteraction } from '../../../src/interaction/interface/common';

describe('BaseTrigger', () => {
it('unregisters every event in an array when released', () => {
const handler = jest.fn();
const event = {
on: jest.fn(),
off: jest.fn(),
emit: jest.fn()
};
const trigger = new (class extends BaseTrigger<IBaseTriggerOptions> {
protected getEvents(): Array<{ type: string | string[]; handler: ITriggerEventHandler }> {
return [{ type: ['pointerdown', 'pointerup'], handler }];
}
})({ event, interaction: {} as IInteraction });

trigger.init();
event.on.mockClear();
event.off.mockClear();

trigger.release();

expect(event.on).not.toHaveBeenCalled();
expect(event.off).toHaveBeenNthCalledWith(1, 'pointerdown', handler);
expect(event.off).toHaveBeenNthCalledWith(2, 'pointerup', handler);
});
});
2 changes: 1 addition & 1 deletion packages/vchart/src/interaction/triggers/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export abstract class BaseTrigger<T extends IBaseTriggerOptions> implements ITri
if (evt.type && evt.handler) {
if (isArray(evt.type)) {
evt.type.forEach(evtType => {
evtType && evtType !== 'none' && this.options.event.on(evtType, evt.handler);
evtType && evtType !== 'none' && this.options.event.off(evtType, evt.handler);
});
} else {
evt.type !== 'none' && this.options.event.off(evt.type, evt.handler);
Expand Down
Loading