Track threads & futures spawned in integration tests to make sure logs are in chronological order#4293
Open
Gedochao wants to merge 1 commit into
Open
Conversation
…s are in chronological order
0421b78 to
105d657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These logs often don't match actual tests ending in integration test logs, as we spawn plenty futures, threads and such which may have not been cleaned up (and may still print to outputs). This is an attempt to track those resources, clean them up after each test and ensure we only print a test has ended when it, in fact, has ended.
At least that's the idea.
Checklist
scala-cli fmt .)scalafix(./mill -i __.fix)How much have your relied on LLM-based tools in this contribution?
extensively
How was the solution tested?
existing tests + a unit test for the tracker (I heard you like tests, so I put unit tests in your integration tests 😐)