Skip to content

Track threads & futures spawned in integration tests to make sure logs are in chronological order#4293

Open
Gedochao wants to merge 1 commit into
VirtusLab:mainfrom
Gedochao:maintenance/integration-test-logs-cleanup
Open

Track threads & futures spawned in integration tests to make sure logs are in chronological order#4293
Gedochao wants to merge 1 commit into
VirtusLab:mainfrom
Gedochao:maintenance/integration-test-logs-cleanup

Conversation

@Gedochao
Copy link
Copy Markdown
Contributor

X==== Finishing '<test name>' from <test file>

These logs often don't match actual tests ending in integration test logs, as we spawn plenty futures, threads and such which may have not been cleaned up (and may still print to outputs). This is an attempt to track those resources, clean them up after each test and ensure we only print a test has ended when it, in fact, has ended.
At least that's the idea.

Checklist

  • tested the solution locally and it works
  • ran the code formatter (scala-cli fmt .)
  • ran scalafix (./mill -i __.fix)

How much have your relied on LLM-based tools in this contribution?

extensively

How was the solution tested?

existing tests + a unit test for the tracker (I heard you like tests, so I put unit tests in your integration tests 😐)

@Gedochao Gedochao force-pushed the maintenance/integration-test-logs-cleanup branch from 0421b78 to 105d657 Compare May 28, 2026 10:45
@Gedochao Gedochao marked this pull request as ready for review May 30, 2026 20:46
@Gedochao Gedochao requested review from tgodzik and zielinsky May 30, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant