Skip to content

Conversation

@FrederickEngelhardt
Copy link
Contributor


name: Pull Request
about: depot tools for chromium
title: ''
labels: ''
assignees: ''


Description

Type of Change

  • 🐛 Bug fix (patch)
  • ✨ New feature (minor)
  • 💥 Breaking change (major)
  • 📚 Documentation update
  • 🔒 Security fix
  • 🔧 Maintenance/Refactoring

Release Management

For automatic release on merge, add one of these labels:

  • release:major - Breaking changes, incompatible API changes (bumps 1.x.x → 2.0.0)
  • release:minor - New features, backwards-compatible (bumps x.1.x → x.2.0)

No label = No automatic release (manual release via GitHub Actions later)

Testing

  • Tested on macOS
  • Tested on Linux
  • Tested on WSL
  • Ran ./osa-cli.zsh --scan-secrets (if touching constructors)
  • Ran tests: ./tests/run-tests.zsh

Checklist

  • My code follows the zsh style of this project
  • I have added #!/usr/bin/env zsh shebang to new scripts
  • I have updated documentation (if applicable)
  • No hardcoded secrets (use osa-secret-set instead)
  • All files use .zsh extension (unless intentionally .sh for bash)
  • I have added appropriate release label (release:major or release:minor)

Additional Context

Copilot AI review requested due to automatic review settings December 28, 2025 04:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for installing and initializing depot_tools, a set of utilities required for Chromium development. The implementation registers depot_tools as a new optional component that can be enabled/disabled through configuration files. However, the PR also includes two unrelated utility installation scripts (tree and cmake) and removes a user-specific path from source control.

  • Adds depot_tools component with installation script and shell initialization
  • Updates all configuration YAML files to include the new depot_tools option
  • Modifies CLI to register and handle depot_tools component installation

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
src/zsh/snippets Removes accidentally committed file containing hardcoded user path
src/zsh/plugin-init/depot-tools.zsh Adds shell initialization for depot_tools PATH setup (but not integrated into base.zsh)
src/setup/install-depot-tools.zsh Implements depot_tools installation/update script
src/setup/install-tree.zsh Unrelated: adds tree utility installer (missing shebang, not registered)
src/setup/install-cmake.zsh Unrelated: adds cmake installer (missing shebang, not registered)
osa-cli.zsh Registers depot-tools component and adds to component_keys arrays
configs/*.yaml Adds depot_tools flag to all configuration presets
Comments suppressed due to low confidence (1)

src/zsh/snippets:1

  • This file should not be tracked in git. According to .gitignore line 10, the entire src/zsh/snippets/ directory is intentionally ignored because it contains downloaded snippets installed during setup. This file appears to contain a hardcoded user-specific path (/Users/fre/dev/osa-snippets) which should never be committed. The deletion is correct, but verify this wasn't accidentally committed in a previous change.

@@ -0,0 +1,3 @@
# Install cmake for building C/C++ projects
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing shebang at the beginning of the file. All zsh script files must start with #!/usr/bin/env zsh according to the project's coding guidelines.

Copilot generated this review using guidance from repository custom instructions.
@FrederickEngelhardt FrederickEngelhardt enabled auto-merge (squash) December 29, 2025 19:56
@FrederickEngelhardt FrederickEngelhardt merged commit a3749d8 into main Dec 30, 2025
2 checks passed
@FrederickEngelhardt FrederickEngelhardt deleted the feat/add-depot-tools branch December 30, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants