Skip to content

Treat a stable but not-yet-ready unit profile or car provider as not ready instead of a tune read failure - #217

Merged
Views2k merged 1 commit into
mainfrom
fix/tune-read-not-ready
Nov 18, 2026
Merged

Views2k merged 1 commit into
mainfrom
fix/tune-read-not-ready

Conversation

@Views2k

@Views2k Views2k commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Closes #214

Tools showed two open "Current tune read failed" issues from NativeTuneRead.Require on stable reads: the Steam unit-profile check (0x8004A60A) and the Store car-provider check (0x8004A60F). Both describe game state the reader cannot use yet, not a mismatch: a locale with no active unit profile, and an actor in the source vector whose provider is not attached. Most affected PCs read their tune successfully minutes before and after; one Steam PC had 20 such failures in ten minutes and no success.

What changed

  • NativeTuneRead.RequireReady and TuneNotReadyException (carrying the check and the rejected value) classify these two states as not ready after the usual stability check; a changing read is still reported as a transition.
  • An actor without a provider counts as pending. A lead provider whose vtable slots do not match remains a reader failure: vtable contents are module constants, so that state cannot be transient.
  • TuneCaptureService returns Unavailable with reason not_ready (outcome idle, no incident). The same check not ready for three reads spanning at least 30 seconds in one game session is reported as tune-read-failed with the check code, so a persistent state still reaches Tools. A success, another failure, a new game session or a different check restarts the count.
  • Messages: "The current car's tune isn't ready yet. Refresh and try again." and "No current car is available yet. Drive in the open world, then refresh." The copied details name the check and the observed value.
  • TuneNotReadyException is in the incident and crash exception-type lists.

No unit-preference fallback: a guessed preference would show the tune in units the game is not using.

Verified

  • Wisp.App and Wisp.App.Tests compile locally. New tests in NativeTuneReadBoundaryTests (Steam and Store fixtures), NativeTuneCaptureTests and TuneCaptureServiceIncidentTests cover both not-ready paths, the persistence rule, the restart conditions and the details text.
  • Steam: the unit-profile path is covered by the Steam fixture. Store: the car-provider path is covered by the Store fixture. Both checks run identically on both platforms.

Unverified

  • In-game: which game state leaves the locale without an active unit profile while driving (the one persistent PC). The details now record the profile index for a report.

…ready instead of a tune read failure

A locale without an active unit profile and an actor without its provider are states the game is still setting up, not reader mismatches. They are idle for the player and for Tools; the same stable state read after read for half a minute in one game session is reported as a read failure with the check that rejected it. The copied details name the check and the rejected value.

Closes #214
@Views2k
Views2k marked this pull request as ready for review November 18, 2026 03:09
@Views2k
Views2k merged commit 7b6a3c9 into main Nov 18, 2026
10 checks passed
@Views2k
Views2k deleted the fix/tune-read-not-ready branch November 18, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native tune read fails on a stable but not-yet-ready unit profile or car provider

1 participant