Repository navigation
Treat a stable but not-yet-ready unit profile or car provider as not ready instead of a tune read failure - #217
Merged
Merged
Conversation
…ready instead of a tune read failure A locale without an active unit profile and an actor without its provider are states the game is still setting up, not reader mismatches. They are idle for the player and for Tools; the same stable state read after read for half a minute in one game session is reported as a read failure with the check that rejected it. The copied details name the check and the rejected value. Closes #214
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #214
Tools showed two open "Current tune read failed" issues from
NativeTuneRead.Requireon stable reads: the Steam unit-profile check (0x8004A60A) and the Store car-provider check (0x8004A60F). Both describe game state the reader cannot use yet, not a mismatch: a locale with no active unit profile, and an actor in the source vector whose provider is not attached. Most affected PCs read their tune successfully minutes before and after; one Steam PC had 20 such failures in ten minutes and no success.What changed
NativeTuneRead.RequireReadyandTuneNotReadyException(carrying the check and the rejected value) classify these two states as not ready after the usual stability check; a changing read is still reported as a transition.TuneCaptureServicereturns Unavailable with reasonnot_ready(outcome idle, no incident). The same check not ready for three reads spanning at least 30 seconds in one game session is reported astune-read-failedwith the check code, so a persistent state still reaches Tools. A success, another failure, a new game session or a different check restarts the count.TuneNotReadyExceptionis in the incident and crash exception-type lists.No unit-preference fallback: a guessed preference would show the tune in units the game is not using.
Verified
Unverified