Repository navigation
Correct the installer upgrade handoff and worker launch - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published-version upgrade test closed Wisp before starting its updater, which correctly rejected the exited parent. Keep the installed application open for checksum rejection and close it only after the updater signals a verified handoff.
The hosted lifecycle also stalled with a worker created without a console. Keep its console hidden, drain both output streams concurrently, and retain sanitized failure codes and phase markers. Worker execution, termination, and output draining remain bounded.
Validation: 36 lifecycle and supervisor regression tests passed, including concurrent noisy output, timeout cleanup, handshake ordering, and failure cases. Repository policy and diff checks passed. The existing candidate passed the real v2.7.4-to-v2.7.5 upgrade, bad-checksum rejection, restart, settings and saved-file preservation, manual reinstall, and uninstall using the corrected launch mode: https://github.com/Views2k/Wisp/actions/runs/43943836435.
Application and installer-payload source are unchanged. All required release gates remain in place.
Both complete lifecycle scenarios also passed through the final supervisor entrypoint: https://github.com/Views2k/Wisp/actions/runs/43944700989. Fresh install, same-version update, manual reinstall, and uninstall completed in 44 seconds; the published-version upgrade scenario completed in 47 seconds.