dialog: remove redundant "Menu Type" field from Button Properties Dialog#371
Merged
Conversation
The 'Menu Type' selector was already covered by the specific zone types in 'Button's Type' (ZONE_ITEM_NORMAL, ZONE_ITEM_MODIFIER, etc.). itype is now derived solely from ztype; generic ZONE_ITEM defaults to ITEM_NORMAL. Network protocol byte is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Menu Type" selector in the Button Properties Dialog was redundant.
"Button's Type" already has a dedicated entry for every menu-item
sub-classification:
When any of those specific types were selected, the dialog already
auto-derived
itypefromztypeand hid the Menu Type widget anyway.The widget was only visible for the legacy generic
ZONE_ITEMtype.Changes
item_type(DialogMenu) widget fromZoneDialog.itypeis now derived solely fromztypeinEZ_TypeCBandCorrect(). The genericZONE_ITEMtype defaults toITEM_NORMAL.WInt8(itype)) is unchanged — theserver still sends and receives the same 1-byte item-type value.
Files Modified
term/term_dialog.hh— removeditem_typefield fromZoneDialogterm/term_dialog.cc— removed widget creation,Set,Show, andtwo
item_type.Value()call sites; replaced withitype