Derive the translated resource pack id from the pack contents - #417
Closed
AlexProgrammerDE wants to merge 1 commit into
Closed
AlexProgrammerDE wants to merge 1 commit into
AlexProgrammerDE wants to merge 1 commit into
Conversation
The resource pack pushed to the java client got a random UUID on every join, so the client's server resource pack cache could never be reused and the whole converted pack was re-downloaded and re-applied on every join, adding a 30-75 second hang on the loading screen. Derive the pack id deterministically from the content identities of the advertised resource packs and the ViaBedrock version, so the client reuses its cached copy across joins and only re-downloads when the server's packs or the conversion actually changed.
Collaborator
Author
|
Superseded by draft PR #420, which waits for the effective Bedrock stack and advertises the SHA-1 of the exact converted ZIP so the Java client can cache it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #416.
The resource pack pushed to the Java client got a random UUID on every join, so the client's server resource pack cache could never be reused. The client re-downloaded and fully re-applied the entire converted pack on every join, adding a 30-75 second hang on the loading screen (visible in client logs as a new
server/0000000X/cache entry with a fresh UUID per join, followed by a fullReloading ResourceManagerpass).The pack id is now derived deterministically from the content identities of the advertised resource packs together with the ViaBedrock version:
The packs are sorted before hashing so the id is stable regardless of the order the server advertises them in.
Testing
gradlew buildpasses