Skip to content

Cancel own-player equipment packets in 1.9->1.8 #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianreuth merged 1 commit into from
Oct 18, 2026
Merged

Cancel own-player equipment packets in 1.9->1.8 #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...in/java/com/viaversion/viarewind/protocol/v1_9to1_8/rewriter/EntityPacketRewriter1_9.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,11 @@ public void register() {
public void register() {
map(Types.VAR_INT); // Entity id
handler(wrapper -> {
// todo check if this is correct for the own player
// 1.8 clients write their own equipment to armorInventory[slot] without the -1 offset,
// shifting armor up one slot; the window 0 set slot packets already carry it.
final int entityId = wrapper.get(Types.VAR_INT, 0);
int slot = wrapper.read(Types.VAR_INT);
if (slot == 1) {
if (slot == 1 || entityId == wrapper.user().getEntityTracker(protocol).clientEntityId()) {
wrapper.cancel();
} else if (slot > 1) {
slot -= 1;
Expand Down