use round instead of truncating (matches modern VecDeltaCodec + RelativeMoveUtil)#707
Open
Term4 wants to merge 1 commit into
Open
use round instead of truncating (matches modern VecDeltaCodec + RelativeMoveUtil)#707Term4 wants to merge 1 commit into
Term4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round instead of truncating in DOUBLE_TO_INT_TIMES_32
DOUBLE_TO_INT_TIMES_32 encodes the coordinates for every absolute entity position packet using (int)(value * 32), which truncates toward zero so negative coordinates land 1/32 block closer to zero than they should. Switching to Math.round fixes that and matches the rest of the pipeline: RelativeMoveUtil already rounds the relative-move deltas, and modern MC's VecDeltaCodec does too (see ss of unobfuscated minecraft 26.1 source).