fix(mcp): transient test failures - #1725
Conversation
|
@vgvbot fix CI failures |
This comment was marked as outdated.
This comment was marked as outdated.
|
hey @jmadren, adding you as reviewer since you opened the issue initially, lmk if it fixes your problem 👍 |
|
|
||
| final isDartInstalled = await _dartInstalled(logger: _logger); | ||
| if (!await _dartInstalled(logger: _logger)) { | ||
| return ExitCode.success.code; |
There was a problem hiding this comment.
this was the behavior already, I just moved it as a guard to reduce nesting, but we could return another exitcode like unavailable if needed, it's just not the scope of this PR
There was a problem hiding this comment.
I think unavailable would be more proper, we can change it as a follow up
| /// Logs [error], along with its uncovered lines when it carries any, and | ||
| /// returns the exit code an unmet coverage threshold reports. | ||
| static int handleMinCoverageNotMet( | ||
| MinCoverageNotMet error, { |
There was a problem hiding this comment.
why we moved from positional arguments here?
There was a problem hiding this comment.
the only positional is the error, the other ones are named parameters because one is optional and the other is not the actual error. changed it for readability but we can revert
|
|
||
| final isFlutterInstalled = await _flutterInstalled(logger: _logger); | ||
| if (!await _flutterInstalled(logger: _logger)) { | ||
| return ExitCode.success.code; |
There was a problem hiding this comment.
3 participants
Status
READY
Description
Closes #1722
Fixes the status codes for transient failures in MCP.
Type of Change