fix: honor test annotations - #1724
Closed
marcossevilla wants to merge 2 commits into
Closed
Conversation
marcossevilla
marked this pull request as draft
September 9, 2026 15:35
Member
Author
|
closing since #1726 might contain significant changes that might affect this, so we might as well land that first and continue from there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1723
Honor test suite annotations (
@Timeout,@Tags,@TestOn,@Skip, anddart_test.yamlconfiguration) when the test optimizer generates the aggregated test entry point.Changes
suite_annotationssupport to thetest_optimizerbrick so per-file annotations and suite configuration are preserved.test_cli_runnerto honor these annotations.Checklist