Repository navigation
Rebuild native renderer binaries - #1014
Merged
SimonCropp merged 1 commit intoNov 1, 2026
Merged
SimonCropp merged 1 commit into
SimonCropp merged 1 commit into
Conversation
SimonCropp
added a commit
that referenced
this pull request
Nov 1, 2026
* Put the Windows tray on NotifyIconTray The Windows head drew its own NotifyIcon, built the tracked half of its menu on every open beside fixed items it kept, opened the menu on a left click through NotifyIcon's ShowContextMenu, and registered hot keys against the icon's window. The macOS and Linux heads hand a model to PlatformHeads' tray every tenth of a second, so the menu was two implementations. Now the Windows head's tray is PlatformHeads' NotifyIconTray, which makes the menu from the last model as it opens. The turns every head takes are TrayTurns, which TrayLoop runs for the other two and a WinForms timer runs here, on the message loop the icon's events are raised on. MenuBuilder is only how the menu looks: the font, the directions, the tips and the glyphs, and LeftClickOpensMenu. Hot keys go to the tray's Handle, and balloons are TrayNotificationKind.Warning, as they were. A menu can now be a turn behind the tracker, which the ids make safe: a click is done on the menus it was chosen from. MenuBuilderTest shows the menu through MenuTray, which makes it as NotifyIconTray does with no icon in the notification area, and its images are unchanged. The two tests of rebuilding around kept items go, since there are none now, and MenuOnOpening's own tests in PlatformHeads hold to what is left of that. All seven PlatformHeads pins move to 0.10.0, which has NotifyIconTray's additions and runs build-native's macOS job on macos-15, since GitHub retires macos-14 on November 2. * Rebuild native renderer binaries (#1014) Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilt
diffengine_viewerfromnativefor the runtime identifiers that load one.Windows is not among them: that head renders with WinForms.
Produced by the
build-nativeworkflow from ba43105.