Repository navigation
Bump SkiaSharp and its Linux natives to 4.154.0 together - #1007
Merged
Merged
Conversation
Dependabot bumped each alone (#995, #996), and each failed every Linux job: SkiaSharp 4.154 refuses the 153 native library ("Supported versions of the native libSkiaSharp library are in the range [154.0, 155.0)"). Morph.Skia asks for SkiaSharp 4.153.1 or later, so 4.154.0 satisfies it. Dependabot now groups SkiaSharp* into one pull request, so the two move together from here on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #995 and #996, which can be closed once this merges.
Why those failed. Dependabot bumped
SkiaSharpandSkiaSharp.NativeAssets.Linux.NoDependenciesin separate PRs. SkiaSharp refuses a native library from another version, so each PR failedubuntu-latestand both native Linux jobs:Directory.Packages.propsalready says the two are pinned together for this reason. Windows and macOS get their natives through SkiaSharp itself, so only Linux broke.The change.
.github/dependabot.ymlgroupsSkiaSharp*, so Dependabot opens one PR for both from now on.Tests. Locally on Windows, a Release build had no errors. The viewer tests passed (870, 25 skipped), including the document and SVG ones that draw through Skia, and so did the packaging tests (53). The Linux natives are exercised by CI's Ubuntu and native jobs, which is where the split PRs failed.