Update balanceOf function documentation#1521
Open
red-swan wants to merge 1 commit intoVectorized:mainfrom
Open
Update balanceOf function documentation#1521red-swan wants to merge 1 commit intoVectorized:mainfrom
red-swan wants to merge 1 commit intoVectorized:mainfrom
Conversation
Clarify behavior of balanceOf function regarding token existence and execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify behavior of balanceOf function regarding token existence and execution. Currently it only describes returning zero if the token called does not exist but that is misleading for developers because it will also return zero if the address reverts during its execution or if the address returns less than 32 bytes. This PR adds those to the description of the function.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge test?Pull requests with an incomplete checklist will be thrown out.