Open
Conversation
…ouble notify, and misc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took some time to explore the codebase a bit and cleaned up a few issues I found.
detach()calledBNDebuggerQuitinstead ofBNDebuggerDetachpid_attachsetter was broken and didn't use the correct decorator (was a copy-paste of the port setter stuff), likewise with the doc for it.get_addr_infowasn't usable due to the fact a plain int was passed where the FFI expected a 64-byte buffer__hash__used (pid, pid) instead of (pid, name) which never matched the__eq__SuspendThread/ResumeThreadnever persisted freeze state,GetAllThreads()returns by value, som_isFrozenwas set on a local copyDetachAndWait/QuitAndWaitleaked mutex on early return due tom_targetControlMutexstaying locked ifIsConnected()returned falseRunTosent duplicated stop events to the UI,NotifyStoppedis called in both *Internal and *AndWait, unlike any other operationDbgEngTTDAdapter::Start()didn'treturn false, so may cause it to fall through - this is now fixed.substr(4)would have corrupted themonitorcommand, now it'ssubstr(8).m_parentItempointer to avoid possible garbage read (unlikely but also just consistency)