Add pypdfium2 as optional PDF parser#270
Open
rejojer wants to merge 9 commits into
Open
Conversation
Default behavior unchanged. Users can opt in via pdf_parser="pypdfium2" for cleaner text extraction (no broken words, correct Unicode) and 3-5x faster parsing. PyPDF2 remains the only required dependency; pypdfium2 is lazy-imported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdf_parser="pypdfium2"alongside the existing PyPDF2 defaultpypdfium2is lazy-imported only when selectedReser ve-style broken words, correct Unicode like†/‡) and is roughly 3-5x faster on the corpus inexamples/documents/Changes
utils.py: newread_pdf_pages(doc, pdf_parser)helper with PyPDF2 / pypdfium2 / PyMuPDF branches;get_page_tokensnow a thin wrapper over itclient.pyandretrieve.py: route their directPyPDF2.PdfReadercalls throughread_pdf_pagesso the parser choice flows end-to-end (parser is recorded on the document so cache-miss reads stay consistent)page_index()andPageIndexClient.__init__()acceptpdf_parserparameter (defaultNone, falls back toconfig.yaml)config.yaml:pdf_parser: \"PyPDF2\"defaultrun_pageindex.py:--pdf-parserCLI argrequirements.txt: pypdfium2 noted as optional (no new hard dependency)Usage
Test plan
ConfigLoader().load().pdf_parser == \"PyPDF2\"(default preserved)read_pdf_pages(pdf)byte-identical toPyPDF2.PdfReader(pdf).pages[*].extract_text()get_page_tokens(pdf)with no parser arg produces identical output to pre-PR behaviorpdf_parser=\"pypdfium2\"extracts pages, normalizes\r\nto\n, accepts both file paths andBytesIOValueErrorImportErrorwithpip install pypdfium2hintpage_index()andPageIndexClient.__init__()signatures includepdf_parser