fix: enable npm publishing by setting private to false#4
Open
vapi-tasker[bot] wants to merge 1 commit intomainfrom
Open
fix: enable npm publishing by setting private to false#4vapi-tasker[bot] wants to merge 1 commit intomainfrom
vapi-tasker[bot] wants to merge 1 commit intomainfrom
Conversation
- Change private: true to private: false in package.json to allow npm publish - Fix ESM import for figlet (was using require() which fails in ESM mode) - Add package structure tests to prevent regression Fixes: ERR_MODULE_NOT_FOUND: Cannot find module 'dist/cli/index.js' Linear: VAP-11522 Co-Authored-By: Claude <noreply@anthropic.com>
VAP-11522 [tasker] Add pre-push hook with CI checks to tasker repo
Request from SlackRequested by: tejas look at the pre-push agentic hook added to the atlas repo, it basically resolves all ci checks (test, lint, etc) and guarantees test coverage before pushing to a branch can you implement the same on the tasker repo? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private: truetoprivate: falsein package.json to allow npm publishrequire()which fails in ESM mode)Problem
Users were getting this error when trying to use the
@vapi/bulletproofpackage:Root Causes
private: truein package.json - This setting prevents npm from publishing the package to the registryrequire('figlet')in ESM mode - The package uses"type": "module"which requires ES module imports, butfigletwas imported using CommonJSrequire(), causing runtime errorsChanges
package.json"private": true->"private": falsesrc/ui/banners.tsconst figlet = require('figlet')->import figlet from 'figlet'src/package.test.tsTest Plan
npm run build- generatesdist/cli/index.jscorrectlynpm run test- all 9 tests passnpm run lint- no errorsnpm run typecheck- no errorsnode bin/bulletproof.js --help- CLI works correctlynpm pack --dry-run- package includes all expected filesAfter Merge
Republish the package to npm:
Users will then be able to run
npx bulletproof initsuccessfully.Linear Issue
VAP-11522
OpenCode review: Review command timed out. Continuing to create PR - human code review will verify.
Generated with Claude Code