Skip to content

setupapi: Fix uninitialized len in is_device_instance_linked, use RegGetValueW, and check for refstr#309

Open
xzn wants to merge 2440 commits intoValveSoftware:bleeding-edgefrom
xzn:devinstlinked
Open

setupapi: Fix uninitialized len in is_device_instance_linked, use RegGetValueW, and check for refstr#309
xzn wants to merge 2440 commits intoValveSoftware:bleeding-edgefrom
xzn:devinstlinked

Conversation

@xzn
Copy link
Copy Markdown

@xzn xzn commented Jan 6, 2026

Upstream wine bug: N/A. is_device_instance_linked in devinst.c is Valve's wine only it seems.

This pr does three changes:

  1. Fix uninitialize len before the first RegGetValueW call (which was RegQueryValueExW before the change).
  2. Set len correctly for RegGetValueW/RegQueryValueExW, both of which expect len to be size in bytes instead of count in chars (the case for RegEnumKeyExW).
  3. Check for refstrs and return true if any of them is linked.

Paul Gofman and others added 30 commits November 19, 2025 16:04
@ivyl
setupapi: Don't open reg keys with zero access mask.
3ffeb52 
(cherry picked from commit 1f4a3ff)

CW-Bug-Id: #24524
@ivyl
server: Check for zero access in alloc_handle().
b6394e3 
(cherry picked from commit 3c29dc1)

CW-Bug-Id: #24524
@alexhenrie @ivyl
setupapi: Use wide character string literals.
4cb13d3 
(cherry picked from commit 3290fc1)

CW-Bug-Id: #24524
@ivyl
setupapi/tests: Test disk space list APIs.
a8d7fa1 
(cherry picked from commit 0550f67)

CW-Bug-Id: #24524
@ivyl
setupapi: Get rid of the DISKSPACELIST typedef.
5508fa2 
(cherry picked from commit 5667e9f)

CW-Bug-Id: #24524
@ivyl
setupapi: Implement SetupAddToDiskSpaceList().
dc772d0 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50337
(cherry picked from commit f93be33)

CW-Bug-Id: #24524
@ivyl
setupapi: Correctly implement SetupQuerySpaceRequiredOnDrive().
6c5675d 
(cherry picked from commit f3b7b79)

CW-Bug-Id: #24524
@bernhardu @ivyl
setupapi: Initialize the files member in SetupDuplicateDiskSpaceListW…
ad37b14 
…. (ASan).

(cherry picked from commit d6b5250)

CW-Bug-Id: #24524
@bernhardu @ivyl
setupapi/tests: Fix message of ok statement.
10cf170 
(cherry picked from commit aa54ff4)

CW-Bug-Id: #24524
@ivyl
setupapi: Don't add backslash on empty folder.
e79ee91 
(cherry picked from commit 09bcbc1)

CW-Bug-Id: #24524
@Conmanx360 @ivyl
Revert "setupapi: Implement SetupDiOpenDeviceInterface(A|W)."
faecd4d 
This reverts commit 658d1b9.

CW-Bug-Id: #24524
@rbernon @ivyl
setupapi: Implement SetupDiOpenDeviceInterface(A|W).
4b8bf77 
Changes by Paul Gofman to the original patch:
- check for too short device path;
- allocate strings dynamically;
- set last error accordingly.

(cherry picked from commit 888d5f1)

CW-Bug-Id: #24524
@ivyl
setupapi/tests: Add a test for SetupDiOpenDeviceInterface().
0aea386 
(cherry picked from commit d4f2921)

CW-Bug-Id: #24524
@bernhardu @ivyl
setupapi/tests: Add broken to test_SetupDiOpenDeviceInterface.
6a7b76c 
Followup of d4f2921.

(cherry picked from commit 16d50f7)

CW-Bug-Id: #24524
@besentv @ivyl
setupapi/tests: Add display enum tests.
f01cb57 
(cherry picked from commit 7cbc33f)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi/tests: Add tests for SetupDi{Set,Get}DeviceInterfacePropertyW.
1aa8a3c 
(cherry picked from commit a4a8bf9)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi: Implement SetupDiSetDeviceInterfacePropertyW.
b1b3b77 
(cherry picked from commit 7fa6aea)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi: Implement SetupDiGetDeviceInterfacePropertyW.
6e5c005 
(cherry picked from commit 444b193)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi/tests: Add tests for SetupDiGetDeviceInterfacePropertyKeys.
d56a9ef 
(cherry picked from commit 71ab91d)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi: Implement SetupDiGetDeviceInterfacePropertyKeys.
dcbc513 
(cherry picked from commit f51960c)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi: Implement additional built-in properties in SetupDiGetDevic…
bd075ca 
…eInterfacePropertyW.

(cherry picked from commit c047079)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi/tests: Add additional tests for device instance properties D…
628be35 
…EVPKEY_{DeviceInterface_ClassGuid, Device_InstanceId}.

(cherry picked from commit bfb29c3)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi: Return built-in property keys for device interfaces even wh…
b90bdda 
…en the Properties subkey for the interface doesn't exist.

(cherry picked from commit 07d533a)

CW-Bug-Id: #24524
@julliard @ivyl
setupapi/tests: Don't test an uninitialized value.
2dbeeb9 
(cherry picked from commit d365d66)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi/tests: Add tests for built-in device properties.
fc7d36c 
(cherry picked from commit 350d13a)

CW-Bug-Id: #24524
@vibhavp @ivyl
ntoskrnl.exe/tests: Add tests for built-in properties for PnP device …
0db9a24 
…instances.

(cherry picked from commit 8a5b235)

CW-Bug-Id: #24524
@vibhavp @ivyl
setupapi: Support built-in properties in SetupDiGetDevicePropertyW an…
0fd8df1 
…d CM_Get_DevNode_Property_ExW.

(cherry picked from commit 5692c45)

CW-Bug-Id: #24524
@Conmanx360 @ivyl
ntoskrnl/tests: Add tests for getting IRP_MN_QUERY_DEVICE_TEXT based …
490e23f 
…device properties.

Signed-off-by: Connor McAdams <cmcadams@codeweavers.com>
(cherry picked from commit 5a884a8)
CW-Bug-Id: #24524
@Conmanx360 @ivyl
ntoskrnl: Set DEVPKEY_Device_BusReportedDeviceDesc from driver.
265d4cc 
Signed-off-by: Connor McAdams <cmcadams@codeweavers.com>
(cherry picked from commit 74bca42)
CW-Bug-Id: #24524
@Conmanx360 @ivyl
winebus: Handle IRP_MN_QUERY_DEVICE_TEXT.
ccf59a5 
Signed-off-by: Connor McAdams <cmcadams@codeweavers.com>
(cherry picked from commit 556500e)
CW-Bug-Id: #24524
Paul Gofman and others added 29 commits December 8, 2025 19:44
ntdll: Fix LdrLoadDll() parameters.
ebf6af3 
CW-Bug-Id: #26318
ntdll: Stop walk in RtlWalkFrameChain() if there is no function entry.
967e62c 
CW-Bug-Id: #26318
ntdll: Make VEH registration structure compatible.
003df1e 
CW-Bug-Id: #26318
ntdll: Generate process cookie and return it from NtQueryInformationP…
6445cfd 
…rocess( ProcessCookie ).

CW-Bug-Id: #26318
ntdll: Reimplement RtlEncodePointer / RtlDecodePointer using process …
63714d3 
…cookie.

CW-Bug-Id: #26318
@ziqingh
gdi32: HACK: Force using Microsoft Sans Serif for Thai.
780b38f 
CW-Bug-Id: #26070
@besentv
mf: Prevent the session from starting invalid topologies.
edcf00c 
CW-Bug-Id: #26327
@zzhiyi
winex11.drv: Update the gl_drawable of the top-level window when the …
f15b760 
…visibility of a child window changes.

needs_client_window_clipping() returns FALSE for a top-level window if its child windows are
invisible. After a child window becomes visible, we should update the gl_drawable of the top-level
window. Otherwise, the gl_drawable might still be rendering on-screen and causes black screen or
flickering effects because the child window is not composited on top.

CW-Bug-Id: #26177
kernel32/tests: Disable heap tests which are now crashing on Windows.
418eb91 
Those crash even on 32 bit on current Win11.

CW-Bug-Id: #26343
kernel32/tests: Add more tests for heap total and commit sizes.
def4b96 
CW-Bug-Id: #26343
ntdll: Align commit size in RtlCreateHeap().
c5f2587 
CW-Bug-Id: #26343
ntdll: Compute total size as aligned commit size in RtlCreateHeap().
f090ac3 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56286

CW-Bug-Id: #26343
@rbernon
HACK: winedmo: Assume that AV1 decoder is available.
4786ba9 
CW-Bug-Id: #26348
@rbernon
winedmo: Always use upper case AV1 fourcc in media types.
1d6691c 
CW-Bug-Id: #26348
@LizzyFleckenstein03
mf: Change SESSION_FLAG_RESTARTING to 0x40.
bae282a 
Timeline:

1. cfc9021 removes SESSION_FLAG_PENDING_COMMAND=0x40 upstream.
2. 0627acf adds SESSION_FLAG_RESTARTING=0x40 upstream.
3. 0627acf is cherry-picked as 872f12e with SESSION_FLAG_RESTARTING=0x80, because 0x40 is still occupied by SESSION_FLAG_PENDING_COMMAND.
4. cfc9021 is cherry-picked as ba6e0c3 removing SESSION_FLAG_PENDING_COMMAND, but does not change SESSION_FLAG_RESTARTING back to 0x40.

This caused a desync between upstream and proton. Ideally the cherry-picks should be reordered according to upstream order.

CW-Bug-Id: #24703
@LizzyFleckenstein03
mf: Fix crash when stream is null during sample request.
2993a15 
Windows seems to wait until it receives the MENewStream event(s) before
subscribing to the sink event queues.

CW-Bug-Id: #24703
@besentv
winedmo: Explicily set HEVC mf GUID.
9866d0f 
FFmpeg would provide 'hvc1' instead of 'HEVC'.

CW-Bug-Id: #26327
fixup! fsync: Add WINE_FSYNC_YIELD_TO_WAITERS option.
8aea1a4 
CW-Bug-Id: #26341
ntdll: HACK: Enable WINE_FSYNC_YIELD_TO_WAITERS for From Dust.
21adfc2 
CW-Bug-Id: #26341
wbemprox: Add Win32_SystemEnclosure.SerialNumber.
9a26b8c 
CW-Bug-Id: #26354
wbemprox: Mark Win32_SystemEnclosure.Tag as key column.
c83c4b7 
CW-Bug-Id: #26354
ntdll: HACK: Enable WINE_SIMULATE_WRITECOPY for DCS World.
7c04244 
CW-Bug-Id: #26354
@rbernon
HACK: winedmo: Ignore missing PNG decoders.
2b6975d 
CW-Bug-Id: #26326
@rbernon
mfsrcsnk: Check and set current stream position before reading.
08868a2 
Some custom media stream implementation do not update their current
position after reading and need to be explicitly seeked.

CW-Bug-Id: #26349
mfplat: HACK: Enable the 2d buffer lock optimisation for Darksiders W…
87e9a9a 
…armastered Edition.

CW-Bug-Id: #25560
winegstreamer: HACK: Implement video right edge replication for Disin…
f4d8697 
…tegration.

CW-Bug-Id: #25865
CW-Bug-Id: #26303
kernelbase: Workaround a call with misaligned stack in OpenMutexW().
3cd5fd2 
CW-Bug-Id: #26378
@madewokherd @ivyl
mscoree: Update Wine Mono to 10.4.1.
a21b86f 
Link: https://gitlab.winehq.org/wine/wine/-/merge_requests/9824
@xzn
setupapi: Fix uninitialized len in is_device_instance_linked, use Reg…
b0820fc 
…GetValueW, and check for refstr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.