sharedgpures.sys: Request less permissions to duplicate handles#308
Open
xzn wants to merge 2440 commits intoValveSoftware:bleeding-edgefrom
Open
sharedgpures.sys: Request less permissions to duplicate handles#308xzn wants to merge 2440 commits intoValveSoftware:bleeding-edgefrom
xzn wants to merge 2440 commits intoValveSoftware:bleeding-edgefrom
Conversation
(cherry picked from commit 1f4a3ff) CW-Bug-Id: #24524
(cherry picked from commit 3c29dc1) CW-Bug-Id: #24524
(cherry picked from commit 3290fc1) CW-Bug-Id: #24524
(cherry picked from commit 0550f67) CW-Bug-Id: #24524
(cherry picked from commit 5667e9f) CW-Bug-Id: #24524
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50337 (cherry picked from commit f93be33) CW-Bug-Id: #24524
(cherry picked from commit f3b7b79) CW-Bug-Id: #24524
…. (ASan). (cherry picked from commit d6b5250) CW-Bug-Id: #24524
(cherry picked from commit aa54ff4) CW-Bug-Id: #24524
(cherry picked from commit 09bcbc1) CW-Bug-Id: #24524
This reverts commit 658d1b9. CW-Bug-Id: #24524
Changes by Paul Gofman to the original patch: - check for too short device path; - allocate strings dynamically; - set last error accordingly. (cherry picked from commit 888d5f1) CW-Bug-Id: #24524
(cherry picked from commit d4f2921) CW-Bug-Id: #24524
(cherry picked from commit 7cbc33f) CW-Bug-Id: #24524
(cherry picked from commit a4a8bf9) CW-Bug-Id: #24524
(cherry picked from commit 7fa6aea) CW-Bug-Id: #24524
(cherry picked from commit 444b193) CW-Bug-Id: #24524
(cherry picked from commit 71ab91d) CW-Bug-Id: #24524
(cherry picked from commit f51960c) CW-Bug-Id: #24524
…eInterfacePropertyW. (cherry picked from commit c047079) CW-Bug-Id: #24524
…EVPKEY_{DeviceInterface_ClassGuid, Device_InstanceId}.
(cherry picked from commit bfb29c3)
CW-Bug-Id: #24524
…en the Properties subkey for the interface doesn't exist. (cherry picked from commit 07d533a) CW-Bug-Id: #24524
(cherry picked from commit d365d66) CW-Bug-Id: #24524
(cherry picked from commit 350d13a) CW-Bug-Id: #24524
…instances. (cherry picked from commit 8a5b235) CW-Bug-Id: #24524
…d CM_Get_DevNode_Property_ExW. (cherry picked from commit 5692c45) CW-Bug-Id: #24524
…device properties. Signed-off-by: Connor McAdams <cmcadams@codeweavers.com> (cherry picked from commit 5a884a8) CW-Bug-Id: #24524
Signed-off-by: Connor McAdams <cmcadams@codeweavers.com> (cherry picked from commit 74bca42) CW-Bug-Id: #24524
Signed-off-by: Connor McAdams <cmcadams@codeweavers.com> (cherry picked from commit 556500e) CW-Bug-Id: #24524
CW-Bug-Id: #26318
CW-Bug-Id: #26318
…rocess( ProcessCookie ). CW-Bug-Id: #26318
…cookie. CW-Bug-Id: #26318
CW-Bug-Id: #26070
CW-Bug-Id: #26327
…visibility of a child window changes. needs_client_window_clipping() returns FALSE for a top-level window if its child windows are invisible. After a child window becomes visible, we should update the gl_drawable of the top-level window. Otherwise, the gl_drawable might still be rendering on-screen and causes black screen or flickering effects because the child window is not composited on top. CW-Bug-Id: #26177
Those crash even on 32 bit on current Win11. CW-Bug-Id: #26343
CW-Bug-Id: #26343
CW-Bug-Id: #26343
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56286 CW-Bug-Id: #26343
CW-Bug-Id: #26348
CW-Bug-Id: #26348
Timeline: 1. cfc9021 removes SESSION_FLAG_PENDING_COMMAND=0x40 upstream. 2. 0627acf adds SESSION_FLAG_RESTARTING=0x40 upstream. 3. 0627acf is cherry-picked as 872f12e with SESSION_FLAG_RESTARTING=0x80, because 0x40 is still occupied by SESSION_FLAG_PENDING_COMMAND. 4. cfc9021 is cherry-picked as ba6e0c3 removing SESSION_FLAG_PENDING_COMMAND, but does not change SESSION_FLAG_RESTARTING back to 0x40. This caused a desync between upstream and proton. Ideally the cherry-picks should be reordered according to upstream order. CW-Bug-Id: #24703
Windows seems to wait until it receives the MENewStream event(s) before subscribing to the sink event queues. CW-Bug-Id: #24703
FFmpeg would provide 'hvc1' instead of 'HEVC'. CW-Bug-Id: #26327
CW-Bug-Id: #26341
CW-Bug-Id: #26341
CW-Bug-Id: #26354
CW-Bug-Id: #26354
CW-Bug-Id: #26354
CW-Bug-Id: #26326
Some custom media stream implementation do not update their current position after reading and need to be explicitly seeked. CW-Bug-Id: #26349
…armastered Edition. CW-Bug-Id: #25560
…tegration. CW-Bug-Id: #25865 CW-Bug-Id: #26303
CW-Bug-Id: #26378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue ValveSoftware/Proton#580 (comment)
Upstream wine bug: N/A. sharedgpures.sys and SharedGpuResource is Valve's wine only.
Summary:
PROCESS_ALL_ACCESS is not needed to duplicate handles for the purpose of sharing gpu resources. Requesting it causes OptiScaler's dx11ondx12 to fail on FFXIV (where PROCESS_VM_WRITE is not allowed). Quick tests with OptiScaler in various games seem ok with this change.