VRClientCoreFactory (and presumably HmdSystemFactory) need to be cdecl to match OpenVR SDK (Closes 8749)#8771
Open
twhitehead wants to merge 2 commits intoValveSoftware:proton_10.0from
Open
VRClientCoreFactory (and presumably HmdSystemFactory) need to be cdecl to match OpenVR SDK (Closes 8749)#8771twhitehead wants to merge 2 commits intoValveSoftware:proton_10.0from
twhitehead wants to merge 2 commits intoValveSoftware:proton_10.0from
Conversation
…ll." This reverts commit 454533f. This had no effect on x64 as stdcall and cdecl are both ignored by the compiler. On x86 it was caused a crash due to the OpenVR SDK implicitly declaring the factory function as cdecl (the default). Closes issue ValveSoftware#8749.
Resolves the following linker warnings ld: warning: resolving _HmdSystemFactory@8 by linking to _HmdSystemFactory ld: warning: resolving _VRClientCoreFactory@8 by linking to _VRClientCoreFactory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VRClientCoreFactoryfunction is declared in the OpenVR SDK without a calling convention. According to Microsoft cdecl is the default calling convention for C and C++ functions, so this means that the user side needs VRClientCoreFactory to be cdecl and not stdcall. This only affects x86 as the compiler ignoresstdcallandcdeclwhen compiling for x64 mode. Without this the callingVR_Initfrom x86 code crashes.Also switched the spec file to be
cdeclto get rid of some longstanding linker warnings. Presumably it didn't matter that these were wrong asVRClientCoreFactoryis only called by the OpenVR SDKVR_Init, which manually loads the library, performing an explicit symbol lookup, and calls through acdeclfunction pointer.