Repository navigation
Conversation
keypair.cpp calls alloca without including <malloc.h>, where MSVC declares it. It compiled only because MSVC's <exception> includes <malloc.h>, and only when _HAS_EXCEPTIONS is 1. With exceptions fully disabled (/EHs-c- /D_HAS_EXCEPTIONS=0) the build fails with error C3861: 'alloca': identifier not found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/common/keypair.cppcallsalloca(four places) but doesn't include<malloc.h>, where MSVC declares it.It compiles today only because MSVC's
<exception>header includes<malloc.h>, and only when_HAS_EXCEPTIONSis 1. With exceptions fully disabled (/EHs-c- /D_HAS_EXCEPTIONS=0, e.g. a vcpkg triplet that sets this for every port) the build fails:Seen with MSVC 14.41 (VS 2022), GNS 1.6.0 from vcpkg,
USE_CRYPTO=OpenSSL. Removing only/D_HAS_EXCEPTIONS=0from the same compile command makes it compile; with this include it compiles either way. Other platforms are unaffected (guarded by_WIN32).We carry this as a vcpkg overlay patch for now and have verified it in CI with MSVC (Debug and Release) and the loopback connection test.
🤖 Generated with Claude Code