Skip to content

fix: use try/finally in get_db to prevent PostgreSQL connection leaks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vacbo wants to merge 1 commit into from
+4 −1
Closed

fix: use try/finally in get_db to prevent PostgreSQL connection leaks #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backend/app/api/deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@


def get_db() -> Generator[Session, None, None]:
with Session(engine) as session:
session = Session(engine)
try:
yield session
finally:
session.close()
Comment on lines +22 to +26
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Functional equivalence of context manager vs try/finally for Session

The old code used with Session(engine) as session: yield session, which relies on Session.__enter__ (returns self) and Session.__exit__ (calls self.close()). The new code manually creates the session, yields it, and calls session.close() in a finally block. These are functionally equivalent because SQLAlchemy's Session.__exit__ does nothing beyond calling close() — it does not auto-commit or auto-rollback based on exception status (unlike Session.begin() which does). However, the with statement pattern is more idiomatic and slightly more concise. The refactor doesn't appear to have a clear motivation — both patterns behave identically for this use case.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.



SessionDep = Annotated[Session, Depends(get_db)]
Expand Down