Replace Oracle decode() with CASE WHEN in expression.dst#182
Open
Replace Oracle decode() with CASE WHEN in expression.dst#182
Conversation
Convert three Oracle-specific decode() calls in expressionPctProfileSetParamQuery and expressionPctSamplesParamQueryDirect templates to ANSI-standard CASE WHEN expressions for Postgres compatibility. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
steve-fischer-200
requested changes
Apr 28, 2026
Contributor
steve-fischer-200
left a comment
steve-fischer-200
left a comment
There was a problem hiding this comment.
as is, doesn't handle the case where we have list values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decode()calls inexpression.dstto ANSI-standardCASE WHENexpressionsexpressionPctProfileSetParamQueryandexpressionPctSamplesParamQueryDirectdecode(col, '', '', default)maps directly toCASE WHEN col = '' THEN '' ELSE default ENDTest Plan
ExpressionTwoChannelDirectComparisonandExpressionOneChannelAndReferenceDesign