Skip to content

restyled data viewer and working report headers similar to the new ho…#64

Open
iansargent wants to merge 2 commits into
mainfrom
viewer-report-header-style
Open

restyled data viewer and working report headers similar to the new ho…#64
iansargent wants to merge 2 commits into
mainfrom
viewer-report-header-style

Conversation

@iansargent

Copy link
Copy Markdown
Collaborator

Another frontend PR restyling the data viewer and working report pages (header)

References #60

@FWJK1 FWJK1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments throughout:

  1. iterate through list to populate grid of metrics (though I like the Field Label helper)
  2. hero section seems like it could be itws own page, maybe lightly parameterized to work on both the Analysis and Report pages?

generally I like logic of the code here, good work overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants