Document bitstream and related functions#371
Merged
UsernameFodder merged 4 commits intoUsernameFodder:masterfrom Apr 7, 2026
Merged
Document bitstream and related functions#371UsernameFodder merged 4 commits intoUsernameFodder:masterfrom
UsernameFodder merged 4 commits intoUsernameFodder:masterfrom
Conversation
have a bit more work to do but tired
UsernameFodder
requested changes
Apr 4, 2026
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
UsernameFodder
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This idea of bitstreams has actually already been known since at least 2013 (see "Byte Storage"). Save file storage is optimized down to the bit level, so there's no unused bits. It does this using bitstreams, which are responsible for reading/writing data from/to a buffer, and keeping track of location down to a bit level. Perhaps that's not the best way to explain it, but just take a look at
CopyBitsToStreamandCopyBitsFromStream, and you'll see what I mean. The code at the previous Project Pokemon link also demonstrates this functionality.Anyway, it seems most compression of information for the save file is done through bitstreams, including a bunch of functions from Irdkwia's notes that I've updated accordingly. There are dozens more of these where I still need to figure out what they do, so expect those in a future PR.