Skip to content

fix: add output schema merges to Django replay span #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sohankshirsagar merged 1 commit into from
Apr 14, 2026
Merged

fix: add output schema merges to Django replay span #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions drift/instrumentation/django/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,10 @@ def process_view(
def _capture_replay_output(self, request: HttpRequest, response: HttpResponse, span_info: SpanInfo) -> None:
"""Capture response data on the span for REPLAY mode.

Sets OUTPUT_VALUE so the inbound replay span sent to the CLI includes
the actual response for UI comparison. Skips RECORD-mode concerns like
transforms, trace blocking, and schema merges.
Sets OUTPUT_VALUE and OUTPUT_SCHEMA_MERGES so the inbound replay span
sent to the CLI includes the actual response with correct schema hints
for UI display. Skips RECORD-mode concerns like transforms and trace
blocking.

Args:
request: Django HttpRequest object
Expand Down Expand Up @@ -313,6 +314,9 @@ def _capture_replay_output(self, request: HttpRequest, response: HttpResponse, s

span_info.span.set_attribute(TdSpanAttributes.OUTPUT_VALUE, json.dumps(output_value))

output_schema_merges = build_output_schema_merges(output_value)
span_info.span.set_attribute(TdSpanAttributes.OUTPUT_SCHEMA_MERGES, json.dumps(output_schema_merges))

def _normalize_html_response(self, response: HttpResponse) -> HttpResponse:
"""Normalize HTML response body for REPLAY mode comparison.

Expand Down
Loading