fix(metrics): correct error messages and export_name docstring in get_mean_grouping - #4475
Open
simpleqt wants to merge 2 commits into
Open
fix(metrics): correct error messages and export_name docstring in get_mean_grouping#4475simpleqt wants to merge 2 commits into
simpleqt wants to merge 2 commits into
Conversation
setup.py was deleted in the uv migration (69770c6); the License section still instructed contributors to copy a license header from a link to that file. Point at source-file headers / pyproject.toml instead.
…_mean_grouping - 'Invalid grouping category. Returning a non-group evaluation.' said it returns while the code raises - the unknown-metric message listed table_extraction as valid and omitted the actually-supported object_detection - '.csv or .tsv' messages omitted .txt which the preceding line accepts (3 sites) - the docstring documented export_name; the parameter is export_filename (following it raised TypeError)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Message/docstring corrections in
unstructured/metrics/evaluate.py, each verified against the code:table_extractionas valid while the accepted branches aretext_extraction,element_typeandobject_detection(table_extraction is rejected); added the missingobject_detection..txt, which the preceding line accepts; updated to ".csv, .tsv or .txt".export_name; the parameter isexport_filename(following it raisedTypeError). Summary reference updated too.Checklist
pytest.raises(ValueError), no message matching