fix(staging): report the value's type, not the key's, in Datasaur validation error - #4473
Open
simpleqt wants to merge 1 commit into
Open
fix(staging): report the value's type, not the key's, in Datasaur validation error#4473simpleqt wants to merge 1 commit into
simpleqt wants to merge 1 commit into
Conversation
…idation error type(key) is always str (the dict key name), so a bad value produced a self-contradictory message like "Expected type <class 'str'> for start_idx. Got <class 'str'>". Report type(entity[key]) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
stage_for_datasaur, the validation error usedtype(key)— always<class 'str'>sincekeyis the dict key name — producing self-contradictory messages like "Expected type <class 'str'> for start_idx. Got <class 'str'>" when a value has the wrong type (e.g.start_idx=1.5). Changed totype(entity[key]).Checklist
test_unstructured/staging/test_datasaur.py) asserts onlypytest.raises(ValueError), no message match — safe